-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed checking for empty obj.Body before further actions #986
Conversation
1 similar comment
I swear it passed all tests on my local machine, but one Travis job failed to |
@raviolin sorry for letting you down for this long... I had some time off and lost sight of this issue. Could you please try and rebase against the latest I updated our |
ccac52d
to
21e4d0b
Compare
Thanks a lot @raviolin 👍 In order to get your PR pushed I'll have to ask for at least 1 test for your contribution as requested per our Guidelines on Submitting a Pull Request |
why check for |
21e4d0b
to
c7cca26
Compare
LGTM |
c7cca26
to
24736cd
Compare
Can you remove 'needs tests' label? Or should I add more tests? |
@raviolin I don't know why the label is still there and we haven't merged your PR yet. Sorry for that... again 🐑 🐑 🐑 😞 |
An error is thrown even if response was succesful.
This is the same as #981 only this doesn't break tests. I decided to make a new pull request because it have been almost a month since #981 was created, and it's author doesn't seem willing to fix tests.